diff options
| author | David Goulet <dgoulet@torproject.org> | 2021-05-04 10:37:26 -0400 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2021-05-04 10:37:26 -0400 |
| commit | cf6e72b7020c47ba20677dc19602663723bd8491 (patch) | |
| tree | bf74b64be9a0d1798b07184703b1c565ba5a3e91 /src/feature/hs/hs_service.h | |
| parent | f0260c4cea6da784369e8d47f0b4bf01863c5af5 (diff) | |
| download | tor-cf6e72b7020c47ba20677dc19602663723bd8491.tar.gz tor-cf6e72b7020c47ba20677dc19602663723bd8491.zip | |
hs: Fix ADD_ONION with client authorization
Turns out that passing client authorization keys to ADD_ONION for v3 was
not working because we were not setting the "is_client_auth_enabled"
flag to true once the clients were configured. This lead to the
descriptor being encoded without the clients.
This patch removes that flag and instead adds an inline function that
can be used to check if a given service has client authorization
enabled.
This will be much less error prone of needing to keep in sync the client
list and a flag instead.
Fixes #40378
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'src/feature/hs/hs_service.h')
| -rw-r--r-- | src/feature/hs/hs_service.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/feature/hs/hs_service.h b/src/feature/hs/hs_service.h index f5be37b410..c48f470245 100644 --- a/src/feature/hs/hs_service.h +++ b/src/feature/hs/hs_service.h @@ -230,9 +230,6 @@ typedef struct hs_service_config_t { * HiddenServiceNumIntroductionPoints option. */ unsigned int num_intro_points; - /** True iff the client auth is enabled. */ - unsigned int is_client_auth_enabled : 1; - /** List of hs_service_authorized_client_t's of clients that may access this * service. Specified by HiddenServiceAuthorizeClient option. */ smartlist_t *clients; |