diff options
| author | Nick Mathewson <nickm@torproject.org> | 2015-09-01 09:43:37 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2015-09-01 09:43:37 -0400 |
| commit | 53c99cce5ecf1d9df9245fc91f7c11ee73295293 (patch) | |
| tree | 8708d2e4f605a1dc57f36029f681dd82b34522c2 /src/ext/ed25519 | |
| parent | a55f257d6a601c498f5a114552f97afe468de8a1 (diff) | |
| download | tor-53c99cce5ecf1d9df9245fc91f7c11ee73295293.tar.gz tor-53c99cce5ecf1d9df9245fc91f7c11ee73295293.zip | |
Add a comment about CID 1311630 and why we won't worry about it.
Diffstat (limited to 'src/ext/ed25519')
| -rw-r--r-- | src/ext/ed25519/donna/modm-donna-64bit.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/ext/ed25519/donna/modm-donna-64bit.h b/src/ext/ed25519/donna/modm-donna-64bit.h index b22df2be75..012ea9ea08 100644 --- a/src/ext/ed25519/donna/modm-donna-64bit.h +++ b/src/ext/ed25519/donna/modm-donna-64bit.h @@ -261,6 +261,10 @@ contract256_slidingwindow_modm(signed char r[256], const bignum256modm s, int wi continue; for (b = 1; (b < (soplen - j)) && (b <= 6); b++) { + /* XXX Tor: coverity scan says that r[j+b] can + * overflow, but that's not possible: b < (soplen-j) + * guarantees that b + j < soplen, so b+j < 256, + * so the index doesn't overflow. */ if ((r[j] + (r[j + b] << b)) <= m) { r[j] += r[j + b] << b; r[j + b] = 0; |