diff options
| author | Nick Mathewson <nickm@torproject.org> | 2016-06-02 09:46:12 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2016-06-11 10:11:54 -0400 |
| commit | 53a3b39da1241ba43f63f1515f6ef5167b182cae (patch) | |
| tree | 558ec394f3a02bb8f2b5e887ff70b82231424143 /src/ext/ed25519 | |
| parent | 80f1a2cbbdd0abd509711a5069f31855df5bcd79 (diff) | |
| download | tor-53a3b39da1241ba43f63f1515f6ef5167b182cae.tar.gz tor-53a3b39da1241ba43f63f1515f6ef5167b182cae.zip | |
Add -Wmissing-variable-declarations, with attendant fixes
This is a big-ish patch, but it's very straightforward. Under this
clang warning, we're not actually allowed to have a global variable
without a previous extern declaration for it. The cases where we
violated this rule fall into three roughly equal groups:
* Stuff that should have been static.
* Stuff that was global but where the extern was local to some
other C file.
* Stuff that was only global when built for the unit tests, that
needed a conditional extern in the headers.
The first two were IMO genuine problems; the last is a wart of how
we build tests.
Diffstat (limited to 'src/ext/ed25519')
| -rw-r--r-- | src/ext/ed25519/donna/ed25519-donna-batchverify.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ext/ed25519/donna/ed25519-donna-batchverify.h b/src/ext/ed25519/donna/ed25519-donna-batchverify.h index 43c4923b3e..7c64cce787 100644 --- a/src/ext/ed25519/donna/ed25519-donna-batchverify.h +++ b/src/ext/ed25519/donna/ed25519-donna-batchverify.h @@ -188,7 +188,7 @@ ge25519_multi_scalarmult_vartime(ge25519 *r, batch_heap *heap, size_t count) { } /* not actually used for anything other than testing */ -unsigned char batch_point_buffer[3][32]; +static unsigned char batch_point_buffer[3][32]; static int ge25519_is_neutral_vartime(const ge25519 *p) { |