summaryrefslogtreecommitdiff
path: root/src/core
diff options
context:
space:
mode:
authorAlexander Færøy <ahf@torproject.org>2021-01-19 16:59:13 +0000
committerAlexander Færøy <ahf@torproject.org>2021-01-19 17:08:01 +0000
commit13cf96445377ba97090c759901d2574cdc82ca3c (patch)
tree8dd434edb7206a1c154dece546a7cac0f71e4c5d /src/core
parente5a0c739d4865b300e904d45c413d5c8f0da304c (diff)
downloadtor-13cf96445377ba97090c759901d2574cdc82ca3c.tar.gz
tor-13cf96445377ba97090c759901d2574cdc82ca3c.zip
Remove unnecessary non-fatal assertion.
This patch removes a call to `tor_assert_nonfatal()` if `extend_info_from_node()` returns NULL. This is unnecessary as we already handle the case where `info` is NULL in the next `if (!info) { ... }` block in the code. See: tor#32666.
Diffstat (limited to 'src/core')
-rw-r--r--src/core/or/circuitbuild.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/core/or/circuitbuild.c b/src/core/or/circuitbuild.c
index ea32a5bc57..c0c918abe4 100644
--- a/src/core/or/circuitbuild.c
+++ b/src/core/or/circuitbuild.c
@@ -2456,7 +2456,6 @@ onion_extend_cpath(origin_circuit_t *circ)
choose_good_middle_server(purpose, state, circ->cpath, cur_len);
if (r) {
info = extend_info_from_node(r, 0);
- tor_assert_nonfatal(info);
}
}