summaryrefslogtreecommitdiff
path: root/src/common
diff options
context:
space:
mode:
authorAlexander Færøy <ahf@0x90.dk>2017-06-28 09:57:58 -0400
committerAlexander Færøy <ahf@0x90.dk>2017-06-28 10:00:24 -0400
commitc239b2fc9c19d7c146888b534a8b51a88df03326 (patch)
tree2faeef704ab4446538d74de6272c6e22fd435e2c /src/common
parent2cd49d9ea6f8bad20215ad17d5057a8eea8e39e8 (diff)
downloadtor-c239b2fc9c19d7c146888b534a8b51a88df03326.tar.gz
tor-c239b2fc9c19d7c146888b534a8b51a88df03326.zip
Fix crash in LZMA module when the Sandbox is enabled.
This patch fixes a crash in our LZMA module where liblzma will allocate slightly more data than it is allowed to by its limit, which leads to a crash. See: https://bugs.torproject.org/22751
Diffstat (limited to 'src/common')
-rw-r--r--src/common/sandbox.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/common/sandbox.c b/src/common/sandbox.c
index aae0705af4..52caa4fcc6 100644
--- a/src/common/sandbox.c
+++ b/src/common/sandbox.c
@@ -19,8 +19,14 @@
#define _LARGEFILE64_SOURCE
#endif
-/** Malloc mprotect limit in bytes. */
-#define MALLOC_MP_LIM (16*1024*1024)
+/** Malloc mprotect limit in bytes.
+ *
+ * 28/06/2017: This value was increased from 16 MB to 20 MB after we introduced
+ * LZMA support in Tor (0.3.1.1-alpha). We limit our LZMA coder to 16 MB, but
+ * liblzma have a small overhead that we need to compensate for to avoid being
+ * killed by the sandbox.
+ */
+#define MALLOC_MP_LIM (20*1024*1024)
#include <stdio.h>
#include <string.h>