diff options
| author | Nick Mathewson <nickm@torproject.org> | 2016-09-22 11:22:11 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2016-11-03 08:40:11 -0400 |
| commit | f156156d56ec61394eb814397c33557762870809 (patch) | |
| tree | 62348be6bc50bb820c065af59b05a5b33f6c1369 /src/common/tortls.c | |
| parent | b978494ed994cdca7e79ed2e7d256c631391c84d (diff) | |
| download | tor-f156156d56ec61394eb814397c33557762870809.tar.gz tor-f156156d56ec61394eb814397c33557762870809.zip | |
Audit use of tor_tls_cert_get_key().
This function is allowed to return NULL if the certified key isn't
RSA. But in a couple of places we were treating this as a bug or
internal error, and in one other place we weren't checking for it at
all!
Caught by Isis during code review for #15055. The serious bug was
only on the 15055 branch, thank goodness.
Diffstat (limited to 'src/common/tortls.c')
| -rw-r--r-- | src/common/tortls.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/tortls.c b/src/common/tortls.c index eb24411a78..e3550b24d5 100644 --- a/src/common/tortls.c +++ b/src/common/tortls.c @@ -814,7 +814,7 @@ tor_tls_get_my_client_auth_key(void) /** * Return a newly allocated copy of the public key that a certificate - * certifies. Return NULL if the cert's key is not RSA. + * certifies. Watch out! This returns NULL if the cert's key is not RSA. */ crypto_pk_t * tor_tls_cert_get_key(tor_x509_cert_t *cert) |