aboutsummaryrefslogtreecommitdiff
path: root/src/common/compat_time.c
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2017-10-19 13:42:28 -0400
committerNick Mathewson <nickm@torproject.org>2017-10-19 13:42:28 -0400
commit35746a9ee75608e7b2393e4519adca602bf2615f (patch)
tree3ed466046fe6cb7a0a6858c2b47765e2be459f3c /src/common/compat_time.c
parent09562421589c055a6cb49c802a248f727390d158 (diff)
downloadtor-35746a9ee75608e7b2393e4519adca602bf2615f.tar.gz
tor-35746a9ee75608e7b2393e4519adca602bf2615f.zip
Comment-only change: annotate exit() calls.
Sometimes when we call exit(), it's because the process is completely hopeless: openssl has a broken AES-CTR implementation, or the clock is in the 1960s, or something like that. But sometimes, we should return cleanly from tor_main() instead, so that embedders can keep embedding us and start another Tor process. I've gone through all the exit() and _exit() calls to annotate them with "exit ok" or "XXXX bad exit" -- the next step will be to fix the bad exit()s. First step towards 23848.
Diffstat (limited to 'src/common/compat_time.c')
-rw-r--r--src/common/compat_time.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/common/compat_time.c b/src/common/compat_time.c
index 1ce6f5ce4e..7fd4281ade 100644
--- a/src/common/compat_time.c
+++ b/src/common/compat_time.c
@@ -90,7 +90,7 @@ tor_gettimeofday(struct timeval *timeval)
if (ft.ft_64 < EPOCH_BIAS) {
/* LCOV_EXCL_START */
log_err(LD_GENERAL,"System time is before 1970; failing.");
- exit(1);
+ exit(1); // exit ok: system clock is broken.
/* LCOV_EXCL_STOP */
}
ft.ft_64 -= EPOCH_BIAS;
@@ -102,7 +102,7 @@ tor_gettimeofday(struct timeval *timeval)
log_err(LD_GENERAL,"gettimeofday failed.");
/* If gettimeofday dies, we have either given a bad timezone (we didn't),
or segfaulted.*/
- exit(1);
+ exit(1); // exit ok: gettimeofday failed.
/* LCOV_EXCL_STOP */
}
#elif defined(HAVE_FTIME)