diff options
| author | Nick Mathewson <nickm@torproject.org> | 2007-02-26 18:01:23 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2007-02-26 18:01:23 +0000 |
| commit | 82e2d6001af8867851f43dbfa0f56997f503aa29 (patch) | |
| tree | 6032b39a8b5da3b609aeeda2d46b2d0933a164a7 /src/common/aes.c | |
| parent | a5b18f8a6580fc239b508b98ce498e859dc0c65c (diff) | |
| download | tor-82e2d6001af8867851f43dbfa0f56997f503aa29.tar.gz tor-82e2d6001af8867851f43dbfa0f56997f503aa29.zip | |
r11954@catbus: nickm | 2007-02-26 13:01:19 -0500
Note some optimizations that are probably not worth it for 0.1.2.x based on preliminary profiling.
svn:r9659
Diffstat (limited to 'src/common/aes.c')
| -rw-r--r-- | src/common/aes.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/common/aes.c b/src/common/aes.c index df9c4f4d08..fa6de45252 100644 --- a/src/common/aes.c +++ b/src/common/aes.c @@ -35,6 +35,8 @@ const char aes_c_id[] = "$Id$"; * significantly faster than using OpenSSL's EVP code (by about 27%) * and faster than using OpenSSL's AES functions (by about 19%). * The counter-mode optimization saves around 5%. + * + * (XXXX We should actually test this more, and test it regularly.) */ #undef USE_OPENSSL_AES #undef USE_OPENSSL_EVP @@ -183,6 +185,10 @@ void aes_crypt(aes_cnt_cipher_t *cipher, const char *input, size_t len, char *output) { + /* XXXX This function is up to 5% of our runtime in some profiles; + * we should look into unrolling some of the loops; taking advantage + * of alignmement, using a bigger buffer, and so on. Not till after 0.1.2.x, + * though. */ int c = cipher->pos; if (!len) return; |