diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-08-26 12:30:18 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-09-05 16:16:20 -0400 |
| commit | 318de94e49c99335987bfdead899c29908afc5bc (patch) | |
| tree | 982c8f3929f01b546c7382fb34b28b0a2771c9c0 /scripts | |
| parent | c71051882586201f9f2566fa7073e13bf50b60db (diff) | |
| download | tor-318de94e49c99335987bfdead899c29908afc5bc.tar.gz tor-318de94e49c99335987bfdead899c29908afc5bc.zip | |
Fix a bug in practracker's handling of .may_include in headers
I was expecting our filter code to work in a way it didn't. I
thought that saying that DependencyViolation applied to "*" would
hit all of the files -- but actually, "*" wasn't implemented. I had
to say "*.c" and "*.h"
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/maint/practracker/practracker.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/maint/practracker/practracker.py b/scripts/maint/practracker/practracker.py index 6483b88da1..b280a76765 100755 --- a/scripts/maint/practracker/practracker.py +++ b/scripts/maint/practracker/practracker.py @@ -213,7 +213,8 @@ def main(argv): filt.addThreshold(problem.FileSizeItem("*.h", int(args.max_h_file_size))) filt.addThreshold(problem.IncludeCountItem("*.h", int(args.max_h_include_count))) filt.addThreshold(problem.FunctionSizeItem("*.c", int(args.max_function_size))) - filt.addThreshold(problem.DependencyViolationItem("*", int(args.max_dependency_violations))) + filt.addThreshold(problem.DependencyViolationItem("*.c", int(args.max_dependency_violations))) + filt.addThreshold(problem.DependencyViolationItem("*.h", int(args.max_dependency_violations))) # 1) Get all the .c files we care about files_list = util.get_tor_c_files(TOR_TOPDIR) |