diff options
author | Nick Mathewson <nickm@torproject.org> | 2019-03-12 09:32:22 -0400 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2019-03-13 09:27:29 -0400 |
commit | e2512950b69d5f9f030673a15e8cf72b930538c7 (patch) | |
tree | 5ef0933271748bc3fd5c477de5912f14cfff1348 /scripts/maint | |
parent | f0302d51abf2f4c6d7660b82ad5038d1cbf9e5d7 (diff) | |
download | tor-e2512950b69d5f9f030673a15e8cf72b930538c7.tar.gz tor-e2512950b69d5f9f030673a15e8cf72b930538c7.zip |
Improve failure message from check-best-practices
Diffstat (limited to 'scripts/maint')
-rwxr-xr-x | scripts/maint/practracker/practracker.py | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/scripts/maint/practracker/practracker.py b/scripts/maint/practracker/practracker.py index 541c5cbfb3..08b74c264f 100755 --- a/scripts/maint/practracker/practracker.py +++ b/scripts/maint/practracker/practracker.py @@ -133,7 +133,14 @@ def main(): # If new issues were found, try to give out some advice to the developer on how to resolve it. if (found_new_issues): - new_issues_str = "practracker FAILED as indicated by the problem lines above. Please use the exceptions file ({}) to find any previous state of these problems. If you are unable to fix the underlying best-practices issue right now then you need to either update the relevant exception line or add a new one.".format(exceptions_file) + new_issues_str = """\ +FAILURE: practracker found new problems in the code: see warnings above. + +Please fix the problems if you can, and update the exceptions file +({}) if you can't. + +See doc/HACKING/HelpfulTools.md for more information on using practracker.\ +""".format(exceptions_file) print(new_issues_str) sys.exit(found_new_issues) |