diff options
| author | David Goulet <dgoulet@torproject.org> | 2020-04-07 09:04:01 -0400 |
|---|---|---|
| committer | teor <teor@torproject.org> | 2020-04-09 11:05:32 +1000 |
| commit | cd2121a1262c2d51b8b9174933db5c985f0ccc55 (patch) | |
| tree | 7022dc0ef8f529d141bd78480147c14e24fbdc8a /doc | |
| parent | 80a306c6e7d20efc44f2f93b559c44a52d952c39 (diff) | |
| download | tor-cd2121a1262c2d51b8b9174933db5c985f0ccc55.tar.gz tor-cd2121a1262c2d51b8b9174933db5c985f0ccc55.zip | |
client: Revert setting PreferIPv6 on by default
This change broke torsocks that by default is expecting an IPv4 for hostname
resolution because it can't ask tor for a specific IP version with the SOCKS5
extension.
PreferIPv6 made it that sometimes the IPv6 could be returned to torsocks that
was expecting an IPv4.
Torsocks is probably a very unique case because the runtime flow is that it
hijacks DNS resolution (ex: getaddrinfo()), gets an IP and then sends it back
for the connect() to happen.
The libc has DNS resolution functions that allows the caller to request a
specific INET family but torsocks can't tell tor to resolve the hostname only
to an IPv4 or IPv6 and thus by default fallsback to IPv4.
Reverting this change into 0.4.3.x series but we'll keep it in the 0.4.4.x
series in the hope that we add this SOCKS5 extension to tor for DNS resolution
and then change torsocks to use that.
Fixes #33804
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/tor.1.txt | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 79809832ca..b2014842cd 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -1492,10 +1492,9 @@ The following options are useful only for clients (that is, if requests on this connection. This option is only relevant when SOCKS5 is in use, because SOCKS4 can't handle IPv6. (Allowing IPv6 is the default.) - **NoPreferIPv6**;; + **PreferIPv6**;; Tells exits that, if a host has both an IPv4 and an IPv6 address, - we would prefer to connect to it via IPv4. (IPv6 is the default in - recent versions of Tor.) + we would prefer to connect to it via IPv6. (IPv4 is the default.) **NoDNSRequest**;; Do not ask exits to resolve DNS addresses in SOCKS5 requests. Tor will connect to IPv4 addresses, IPv6 addresses (if IPv6Traffic is set) and @@ -1537,7 +1536,7 @@ The following options are useful only for clients (that is, if When serving a hostname lookup request on this port that should get automapped (according to AutomapHostsOnResolve), if we could return either an IPv4 or an IPv6 answer, prefer - an IPv4 answer. (Tor prefers IPv6 by default.) + an IPv4 answer. (Tor prefers IPv4 by default.) **PreferSOCKSNoAuth**;; Ordinarily, when an application offers both "username/password authentication" and "no authentication" to Tor via SOCKS5, Tor |