Implement the common case of ATTACHSTREAM.

svn:r3751

2 files changed, 14 insertions, 5 deletions

diff --git a/doc/TODO b/doc/TODO
index 6d2dfa2e86..07288ff93c 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -72,13 +72,15 @@ N  . Implement pending controller features.
     - EXTENDCIRCUIT
 R     - revised circ selection stuff.
       - Implement controller interface.
-    - ATTACHSTREAM
-      - Make streams have an 'unattached and not-automatically-attachable'
+    . ATTACHSTREAM
+      o Make streams have an 'unattached and not-automatically-attachable'
         state. ("Controller managed.")
-      - Add support to put new streams into this state rather than try to
+      o Add support to put new streams into this state rather than try to
         attach them automatically.  ("Hidden" config option.)
+      o Implement 'attach stream X to circuit Y' logic.
       - Time out never-attached streams.
-      - Implement 'attach stream X to circuit Y' logic.
+      - If we never get a CONNECTED back, we should put the stream back in
+        CONTROLLER_WAIT, not in CIRCUIT_WAIT.
     - Tests for new controller features
 R . HTTPS proxy for OR CONNECT stuff. (For outgoing SSL connections to
     other ORs.)
diff --git a/doc/control-spec.txt b/doc/control-spec.txt
index 0f197c46a1..0571d068fe 100644
--- a/doc/control-spec.txt
+++ b/doc/control-spec.txt
@@ -100,6 +100,10 @@ the message.
                [The server didn't have enough of a given resource to
                 fulfill a given request.]
 
+        0x000A No such stream
+
+        0x000B No such circuit.
+
   The rest of the body should be a human-readable description of the error.
 
   In general, new error codes should only be added when they don't fall under
@@ -182,7 +186,7 @@ the message.
 
                 Status [1 octet]
                    (Sent connect=0,sent resolve=1,succeeded=2,failed=3,
-                    closed=4, new=5)
+                    closed=4, new connection=5, new resolve request=6)
                 Stream ID [4 octets]
                    (Must be unique to Tor process/time)
                 Target (NUL-terminated address-port string]
@@ -351,6 +355,9 @@ the message.
   associated with the specified circuit.  Each stream may be associated with
   at most one circuit, and multiple streams may share the same circuit.
 
+  If the circuit ID is 0, responsibility for attaching the given stream is
+  returned to Tor.
+
 3.16 POSTDESCRIPTOR (Type 0x000F)
 
   [Proposal; not finalized]