diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-03-14 11:32:53 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-03-14 11:32:53 -0400 |
| commit | 99ec44de45e6fb38af0a99b82728f7d359ca5bf5 (patch) | |
| tree | ca0e2424f638a6224d34b50efc610a596e621d18 /doc/HACKING | |
| parent | 5b5ec52cae4f886d451579f45984afcf96f3f3c2 (diff) | |
| parent | dfde58db6b4ca0b406b872d7b049efbe07d7a0fe (diff) | |
| download | tor-99ec44de45e6fb38af0a99b82728f7d359ca5bf5.tar.gz tor-99ec44de45e6fb38af0a99b82728f7d359ca5bf5.zip | |
Merge remote-tracking branch 'chelseakomlo/documentation_integ_tests'
Diffstat (limited to 'doc/HACKING')
| -rw-r--r-- | doc/HACKING/CodingStandards.md | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/doc/HACKING/CodingStandards.md b/doc/HACKING/CodingStandards.md index 01212a9919..c7787a72cc 100644 --- a/doc/HACKING/CodingStandards.md +++ b/doc/HACKING/CodingStandards.md @@ -4,9 +4,10 @@ Coding conventions for Tor tl;dr: - Run configure with `--enable-fatal-warnings` - - Run `make check-spaces` to catch whitespace errors - Document your functions - Write unit tests + - Run `make test-full` to test against all unit and integration tests. + - Run `make distcheck` to ensure the distribution works - Add a file in `changes` for your branch. Patch checklist @@ -22,10 +23,12 @@ preference) Did you remember... - To build your code while configured with `--enable-fatal-warnings`? - - To run `make check-spaces` on your code? - To run `make check-docs` to see whether all new options are on the manpage? - To write unit tests, as possible? + - To run `make test-full` to test against all unit and integration tests (or + `make test-full-online` if you have a working connection to the internet)? + - To test that the distribution will actually work via `make distcheck`? - To base your code on the appropriate branch? - To include a file in the `changes` directory as appropriate? |