diff options
author | Nick Mathewson <nickm@torproject.org> | 2016-04-12 21:12:10 -0400 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2016-04-12 21:12:10 -0400 |
commit | 4043f2c95f4a47e69edc4d451673b7ffda066768 (patch) | |
tree | 31e26cf0e4e2d05ab75909d404b5c589896cacc5 /doc/HACKING | |
parent | bd34edc18d6e21f5ba7bddf5a7ebe6582e8dc639 (diff) | |
download | tor-4043f2c95f4a47e69edc4d451673b7ffda066768.tar.gz tor-4043f2c95f4a47e69edc4d451673b7ffda066768.zip |
Adopt the LCOV convention for marking lines as unreachable by tests.
Document this convention.
Add a script to post-process .gcov files in order to stop nagging us
about excluded lines.
Teach cov-diff to handle these post-processed files.
Closes ticket 16792
Diffstat (limited to 'doc/HACKING')
-rw-r--r-- | doc/HACKING/WritingTests.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/doc/HACKING/WritingTests.md b/doc/HACKING/WritingTests.md index bd2ee0ea9c..7bcadc6087 100644 --- a/doc/HACKING/WritingTests.md +++ b/doc/HACKING/WritingTests.md @@ -109,6 +109,19 @@ To count new or modified uncovered lines in D2, you can run: ./scripts/test/cov-diff ${D1} ${D2}" | grep '^+ *\#' | wc -l +### Marking lines as unreachable by tests + +You can mark a specific line as unreachable by using the special +string LCOV_EXCL_LINE. You can mark a range of lines as unreachable +with LCOV_EXCL_START... LCOV_EXCL_STOP. Note that older versions of +lcov don't understand these lines. + +You can post-process .gcov files to make these lines 'unreached' by +running ./scripts/test/cov-exclude on them. + +Note: you should never do this unless the line is meant to 100% +unreachable by actual code. + What kinds of test should I write? ---------------------------------- |