diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-09-22 15:14:36 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-09-22 15:14:36 -0400 |
| commit | cbea334d6ba564c8b251ada832e26211f8172363 (patch) | |
| tree | 65250b02ec37cb13fd98625208bc3ebb1886e8cf /doc/HACKING/HowToReview.md | |
| parent | 22e2c3bf7db7f4112e100c4c0529c400f67f09f0 (diff) | |
| download | tor-cbea334d6ba564c8b251ada832e26211f8172363.tar.gz tor-cbea334d6ba564c8b251ada832e26211f8172363.zip | |
Mention even more about changes files in doc/HACKING
Diffstat (limited to 'doc/HACKING/HowToReview.md')
| -rw-r--r-- | doc/HACKING/HowToReview.md | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/doc/HACKING/HowToReview.md b/doc/HACKING/HowToReview.md index d53318942f..2d1f3d1c9e 100644 --- a/doc/HACKING/HowToReview.md +++ b/doc/HACKING/HowToReview.md @@ -19,6 +19,8 @@ Top-level smell-checks - Does `make check-spaces` pass? +- Does `make check-changes` pass? + - Does it have a reasonable amount of tests? Do they pass? Do they leak memory? @@ -32,6 +34,7 @@ Top-level smell-checks - If this changes Tor's behavior on the wire, is there a design proposal? +- If this changes anything in the code, is there a "changes" file? Let's look at the code! |