diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-02-14 12:21:31 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-02-28 08:16:33 -0500 |
| commit | 1582adabbb13871bcf6f91be4fa8523aeb36f79a (patch) | |
| tree | 7d31fb0d465bc9dbd4149dcc096e79dcb87f3897 /changes | |
| parent | f5995692dadf9bc038455d7e701be84937f28d82 (diff) | |
| download | tor-1582adabbb13871bcf6f91be4fa8523aeb36f79a.tar.gz tor-1582adabbb13871bcf6f91be4fa8523aeb36f79a.zip | |
Change approach to preventing duplicate guards.
Previously I'd made a bad assumption in the implementation of
prop271 in 0.3.0.1-alpha: I'd assumed that there couldn't be two
guards with the same identity. That's true for non-bridges, but in
the bridge case, we allow two bridges to have the same ID if they
have different addr:port combinations -- in order to have the same
bridge ID running multiple PTs.
Fortunately, this assumption wasn't deeply ingrained: we stop
enforcing the "one guard per ID" rule in the bridge case, and
instead enforce "one guard per <id,addr,port>".
We also needed to tweak our implementation of
get_bridge_info_for_guard, since it made the same incorrect
assumption.
Fixes bug 21027; bugfix on 0.3.0.1-alpha.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug21027 | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/changes/bug21027 b/changes/bug21027 new file mode 100644 index 0000000000..d20df876fa --- /dev/null +++ b/changes/bug21027 @@ -0,0 +1,8 @@ + o Major bugfixes (bridges): + + - When the same bridge is configured multiple times at different + address:port combinations (but with the same identity), treat + those bridge instances as separate guards. This allows clients to + configure the same bridge with multiple pluggable transports, once + again. Fixes bug 21027; bugfix on 0.3.0.1-alpha. + |