summaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorDavid Goulet <dgoulet@torproject.org>2019-06-03 14:31:51 -0400
committerDavid Goulet <dgoulet@torproject.org>2019-06-03 14:31:51 -0400
commit33382184b67d43b859de2f50d24cc7955b9f0db7 (patch)
tree81e03745fb038a9d609d6ed2e49178b05cde3288 /changes
parent180048e013c06ee67c053186aab46ff94cea0489 (diff)
downloadtor-33382184b67d43b859de2f50d24cc7955b9f0db7.tar.gz
tor-33382184b67d43b859de2f50d24cc7955b9f0db7.zip
sendme: Do not decrement window in a log_debug()
If "Log debug ..." is not set, the decrement never happens. This lead to the package/deliver window to be out of sync at the stream level and thus breaking the connection after 50+ cells. Fixes #30628 Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'changes')
-rw-r--r--changes/ticket306285
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/ticket30628 b/changes/ticket30628
new file mode 100644
index 0000000000..7128c5acf7
--- /dev/null
+++ b/changes/ticket30628
@@ -0,0 +1,5 @@
+ o Major bugfixes (Flow Control, SENDME):
+ - The decrement of the stream-level package window was done in a log_debug()
+ statement meaning that if the debug logs were not enabled, the decrement
+ would never happen and thus the window would be out of sync with the other
+ end point. Fixes bug 30628; bugfix on 0.4.1.1-alpha.