diff options
| author | David Goulet <dgoulet@torproject.org> | 2021-02-11 16:14:56 -0500 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2021-02-12 13:13:43 -0500 |
| commit | dfcb050bbf424b6e72acb1bccd2dd99e8c96cb8c (patch) | |
| tree | f04f0978024f7358999fbfda68fc80ad039c92ec /changes | |
| parent | 80b33ae1ca148753558afa7bc8b43ba3df6d7948 (diff) | |
| download | tor-dfcb050bbf424b6e72acb1bccd2dd99e8c96cb8c.tar.gz tor-dfcb050bbf424b6e72acb1bccd2dd99e8c96cb8c.zip | |
config: Do not compare for duplicate ORPorts with different addresses
We were just looking at the family which is not correct because it is possible
to have two explicit ORPort for the same family but different addresses. One
example is:
ORPort 127.0.0.1:9001 NoAdvertise
ORPort 1.2.3.4:9001 NoListen
Thus, this patch now ignores ports that have different addresses iff they are
both explicits. That is, if we have this example, also two different
addresses:
ORPort 9001
ORPort 127.0.0.1:9001 NoAdvertise
The first one is implicit and second one is explicit and thus we have to
consider them for removal which in this case would remove the "ORPort 9001" in
favor of the second port.
Fixes #40289
Signe-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/ticket40289 | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changes/ticket40289 b/changes/ticket40289 new file mode 100644 index 0000000000..cdb36825b0 --- /dev/null +++ b/changes/ticket40289 @@ -0,0 +1,6 @@ + o Minor bugfixes (relay, config): + - Fix a problem in the removal of duplicate ORPort from the internal port + list when loading config file. We were removing wrong ports breaking valid + torrc uses cases for multiple ORPorts of the same address family. Fixes + bug 40289; bugfix on 0.4.5.1-alpha. + |