summaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2020-01-06 09:02:49 -0500
committerNick Mathewson <nickm@torproject.org>2020-01-06 09:24:15 -0500
commitdca2629480f143ed8deb71b73b15c7c5ff890571 (patch)
tree35a5009537b9be4ad87f076962a4ceb0e41277dc /changes
parent13216f848a120760fa372b9ae8f6d0840f4a83ba (diff)
downloadtor-dca2629480f143ed8deb71b73b15c7c5ff890571.tar.gz
tor-dca2629480f143ed8deb71b73b15c7c5ff890571.zip
Use tor_api.h entry points in ntmain.c.
When we updated main.c to use the same entry points as tor_api.h, we didn't update ntmain.c. This led to bugs as the two got out of sync. There are two calls that we drop in this patch: first, I drop the call to set_main_thread(), since that's redundant with the init function in compat_winthreads.c (but see #32884). Second, I drop the check for CMD_RUN_TOR: I'll add that back with a subsequent commit. Closes ticket 32883.
Diffstat (limited to 'changes')
-rw-r--r--changes/bug328835
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/bug32883 b/changes/bug32883
new file mode 100644
index 0000000000..6a15e0221b
--- /dev/null
+++ b/changes/bug32883
@@ -0,0 +1,5 @@
+ o Code simplification and refactoring (windows services):
+ - The windows service logic now uses the tor_api.h entry points, to
+ avoid needless code duplication, and to prevent bugs related to
+ the different entry points getting out of sync. Closes ticket
+ 32883.