diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-04-30 14:43:35 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-04-30 14:45:51 -0400 |
| commit | 309467c64e007ea6841c07fdee35eaff0146d541 (patch) | |
| tree | 88c91e103774d713036dfd7b465db24400fdb3ff /changes | |
| parent | 847fc3280d4a77859c28f4c6c91c2cdf863c5c43 (diff) | |
| download | tor-309467c64e007ea6841c07fdee35eaff0146d541.tar.gz tor-309467c64e007ea6841c07fdee35eaff0146d541.zip | |
Rename tor_mem_is_zero to fast_mem_is_zero()
For memeq and friends, "tor_" indicates constant-time and "fast_"
indicates optimized. I'm fine with leaving the constant-time
"safe_mem_is_zero" with its current name, but the "tor_" prefix on
the current optimized version is misleading.
Also, make the tor_digest*_is_zero() uniformly constant-time, and
add a fast_digest*_is_zero() version to use as needed.
A later commit in this branch will fix all the users of
tor_mem_is_zero().
Closes ticket 30309.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug30309 | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/changes/bug30309 b/changes/bug30309 new file mode 100644 index 0000000000..6cbbe8d156 --- /dev/null +++ b/changes/bug30309 @@ -0,0 +1,3 @@ + o Code simplification and refactoring: + - Rename tor_mem_is_zero() to fast_mem_is_zero(), to emphasize that + it is not a constant-time function. Closes ticket 30309. |