diff options
| author | Nick Mathewson <nickm@torproject.org> | 2018-09-18 12:40:18 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2018-09-18 12:40:18 -0400 |
| commit | ea5792f333b1b92306d20e60b5e12bb0633aa740 (patch) | |
| tree | 48f82aafe09b28d36c8034e800ef966d006b0960 /changes | |
| parent | 50367d06f2ae1a06e6553a8925b5aded7f610082 (diff) | |
| download | tor-ea5792f333b1b92306d20e60b5e12bb0633aa740.tar.gz tor-ea5792f333b1b92306d20e60b5e12bb0633aa740.zip | |
Make crypto_strongest_rand() non-mockable
Instead, have it call a mockable function. We don't want
crypto_strongest_rand() to be mockable, since doing so creates a
type error when we call it from ed25519-donna, which we do not build
in a test mode.
Fixes bug 27728; bugfix on 0.3.5.1-alpha
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug27728 | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug27728 b/changes/bug27728 new file mode 100644 index 0000000000..f0b3e6dc05 --- /dev/null +++ b/changes/bug27728 @@ -0,0 +1,7 @@ + o Minor bugfixes (compilation): + - Compile the ed25519-donna code with a correct declaration of + crypto_strongest_rand(). Previously, we build it with one type, + but link it against another in the unit tests, which caused + compilation failures with LTO enabled, and which could have + caused other undefined behavior in the tests. Fixes bug 27728; + bugfix on 0.3.5.1-alpha. |