diff options
| author | David Goulet <dgoulet@torproject.org> | 2018-01-31 14:15:02 -0500 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2018-01-31 14:15:02 -0500 |
| commit | fbc455cbd224aaf28c613ed92bbaee656291efec (patch) | |
| tree | 40486321ab7fda0b61fd3da012e42fec3853fa67 /changes | |
| parent | c85f78e74c52d19b575618d031e67b64210c14fc (diff) | |
| download | tor-fbc455cbd224aaf28c613ed92bbaee656291efec.tar.gz tor-fbc455cbd224aaf28c613ed92bbaee656291efec.zip | |
ns: Add a before and after consensus has changed notification
In 0.3.2.1-alpha, we've added notify_networkstatus_changed() in order to have
a way to notify other subsystems that the consensus just changed. The old and
new consensus are passed to it.
Before this patch, this was done _before_ the new consensus was set globally
(thus NOT accessible by getting the latest consensus). The scheduler
notification was assuming that it was set and select_scheduler() is looking at
the latest consensus to get the parameters it might needs. This was very wrong
because at that point it is still the old consensus set globally.
This commit changes the notify_networkstatus_changed() to be the "before"
function and adds an "after" notification from which the scheduler subsystem
is notified.
Fixes #24975
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug24975 | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changes/bug24975 b/changes/bug24975 new file mode 100644 index 0000000000..32a5dfc929 --- /dev/null +++ b/changes/bug24975 @@ -0,0 +1,6 @@ + o Major bugfixes (scheduler, consensus): + - A logic in the code was preventing the scheduler subystem to properly + make a decision based on the latest consensus when it arrives. This lead + to the scheduler failing to notice any consensus parameters that might + have changed between consensuses. Fixes bug 24975; bugfix on + 0.3.2.1-alpha. |