diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-07-18 10:12:19 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-07-18 10:12:19 -0400 |
| commit | 78dec943074c26747abc7a68cd6aec5269100569 (patch) | |
| tree | a721c042b10fef57a255f0f29f448051922171df /changes | |
| parent | efdf6c711810cfa951741071cb7b67c3a76f2651 (diff) | |
| download | tor-78dec943074c26747abc7a68cd6aec5269100569.tar.gz tor-78dec943074c26747abc7a68cd6aec5269100569.zip | |
Tweaks to 6400 changes file and docs as suggested by arma
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/smartlist_foreach | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/changes/smartlist_foreach b/changes/smartlist_foreach index 0a6c960427..2fd3a1a85c 100644 --- a/changes/smartlist_foreach +++ b/changes/smartlist_foreach @@ -1,6 +1,8 @@ o Code simplification and refactoring: - - Do not allow the body of any SMARTLIST_FOREACH block to exceed - 10 lines. Doing so in the past has led to hard-to-debug code. + - Do not use SMARTLIST_FOREACH for any loop whose body exceeds + 10 lines. Doing so in the past has led to hard-to-debug code. The new style is to use the SMARTLIST_FOREACH_{BEGIN,END} pair. - - Do not allow SMARTLIST_FOREACH blocks to nest. Any nested block - ought to be using SMARTLIST_FOREACH_{BEGIN,END}. + Issue 6400. + - Do not nest SMARTLIST_FOREACH blocks within one another. Any + nested block ought to be using SMARTLIST_FOREACH_{BEGIN,END}. + Issue 6400. |