diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-05-12 11:10:35 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-05-12 11:10:35 -0400 |
| commit | 4ba9f3e31702020eaa336ccb33294568cda256eb (patch) | |
| tree | 4bb95303e56a37dc624ef6834886929dfce0ecfe /changes | |
| parent | 3968e8d14b7f6282963223b0fd4f4ca3afb60c61 (diff) | |
| download | tor-4ba9f3e31702020eaa336ccb33294568cda256eb.tar.gz tor-4ba9f3e31702020eaa336ccb33294568cda256eb.zip | |
Track where microdescs are referenced to prevent free errs
On IRC, wanoskarnet notes that if we ever do microdesc_free() on a
microdesc that's in the nodelist, we're in trouble. Also, we're in
trouble if we free one that's still in the microdesc_cache map.
This code adds a flag to microdesc_t to note where the microdesc is
referenced from, and checks those flags from microdesc_free(). I
don't believe we have any errors here now, but if we introduce some
later, let's log and recover from them rather than introducing
heisenbugs later on.
Addresses bug 3153.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug3153 | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/bug3153 b/changes/bug3153 new file mode 100644 index 0000000000..8754b3df3e --- /dev/null +++ b/changes/bug3153 @@ -0,0 +1,5 @@ + o Minor features: + - Check for and recover from inconsistency in the microdescriptor + cache. This will make it harder for us to accidentally free a + microdescriptor without removing it from the appropriate data + structures. Fixes issue 3135; issue noted by wanoskarnet. |