diff options
| author | Nick Mathewson <nickm@torproject.org> | 2011-12-19 14:37:52 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2011-12-21 11:19:41 -0500 |
| commit | b5e6bbc01dc5d89285aba8a1440a2f5833e531a5 (patch) | |
| tree | 781fc1236d9380cc8271259451edaa4293b9d799 /changes | |
| parent | cefff11950d0b80de02bc956d5eb21ceeb81260c (diff) | |
| download | tor-b5e6bbc01dc5d89285aba8a1440a2f5833e531a5.tar.gz tor-b5e6bbc01dc5d89285aba8a1440a2f5833e531a5.zip | |
Do not even try to keep going on a socket with socklen==0
Back in #1240, r1eo linked to information about how this could happen
with older Linux kernels in response to nmap. Bugs #4545 and #4547
are about how our approach to trying to deal with this condition was
broken and stupid. Thanks to wanoskarnet for reminding us about #1240.
This is a fix for the abovementioned bugs, and is a bugfix on
0.1.0.3-rc.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug1240 | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/changes/bug1240 b/changes/bug1240 new file mode 100644 index 0000000000..657066491c --- /dev/null +++ b/changes/bug1240 @@ -0,0 +1,8 @@ + o Minor bugfixes: + - When running with an older Linux kernel that erroneously responds + to strange nmap behavior by having accept() return successfully + with a zero-length socket, just close the connection. Previously, + we would try harder to learn the remote address: but there was no + such remote address to learn, and our method for trying to learn + it was incorrect. Fixes bugs #1240, #4745, and #4747. Bugfix on + 0.1.0.3-rc. Reported and diagnosed by "r1eo". |