aboutsummaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2013-02-11 15:42:57 -0500
committerNick Mathewson <nickm@torproject.org>2013-02-11 15:42:57 -0500
commitf12fafac5a6ab02fa2544eafef8dead847f7353e (patch)
tree0faa9598c99b7ebe5f0f0eb127f7865fad2677f3 /changes
parent52263b0dda85632ea1deb0f05a83a39d4876f3ab (diff)
downloadtor-f12fafac5a6ab02fa2544eafef8dead847f7353e.tar.gz
tor-f12fafac5a6ab02fa2544eafef8dead847f7353e.zip
Make hidden service authorization work again.
The refactoring in commit 471ab340325 wasn't complete enough: we were checking the auth_len variable, but never actually setting it, so it would never seem that authentication had been provided. This commit also removes a bunch of unused variables from rend_service_introduce, whose unusedness we hadn't noticed because we were wiping them at the end of the function. Fix for bug 8207; bugfix on 0.2.4.1-alpha.
Diffstat (limited to 'changes')
-rw-r--r--changes/bug82077
1 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug8207 b/changes/bug8207
new file mode 100644
index 0000000000..0028d3380f
--- /dev/null
+++ b/changes/bug8207
@@ -0,0 +1,7 @@
+ o Major bugfixes (hidden services):
+ - Allow hidden service authentication to succeed again. When we
+ refactored the hidden service introduction code back in 0.2.4.1-alpha,
+ we didn't update the code that checks whether authentication
+ information is present, causing all authentication checks to
+ return "false". Fix for bug 8207; bugfix on 0.2.4.1-alpha. Found by
+ Coverity; this is CID 718615.