aboutsummaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2016-02-22 11:43:59 -0500
committerNick Mathewson <nickm@torproject.org>2016-03-21 13:23:32 -0400
commit13a31e72db1b009623aa55bd52ffe7390a22623d (patch)
tree85eb1d196ffa02c586ef80bebd00fa1facdf57eb /changes
parentc20e34e1894bed07982fe64d60a1b3fe9403d269 (diff)
downloadtor-13a31e72db1b009623aa55bd52ffe7390a22623d.tar.gz
tor-13a31e72db1b009623aa55bd52ffe7390a22623d.zip
Never vote for an ed key twice.
When generating a vote, and we have two routerinfos with the same ed key, omit the one published earlier. This was supposed to have been solved by key pinning, but when I made key pinning optional, I didn't realize that this would jump up and bite us. It is part of bug 18318, and the root cause of 17668.
Diffstat (limited to 'changes')
-rw-r--r--changes/bug18318_ed7
1 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug18318_ed b/changes/bug18318_ed
new file mode 100644
index 0000000000..af39234d53
--- /dev/null
+++ b/changes/bug18318_ed
@@ -0,0 +1,7 @@
+ o Major bugfixes:
+ - When generating a vote with keypinning disabled, never include two
+ entries for the same ed25519 identity. This bug was causing
+ authorities to generate votes that they could not parse when a router
+ violated key pinning by changing its RSA identity but keeping its
+ Ed25519 identity. Fixes bug 17668; fixes part of bug 18318. Bugfix on
+ 0.2.7.2-alpha.