diff options
| author | cypherpunks <cypherpunks@torproject.org> | 2016-12-18 15:55:37 +0000 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2016-12-23 10:54:17 -0500 |
| commit | 04f21f03221a3888bde376ee1c2daa1effccbb4e (patch) | |
| tree | abb7dc2d13c444706764163fa772b557578c9582 /changes | |
| parent | d3c0b137aff9ae506778c74d885088cbdb535922 (diff) | |
| download | tor-04f21f03221a3888bde376ee1c2daa1effccbb4e.tar.gz tor-04f21f03221a3888bde376ee1c2daa1effccbb4e.zip | |
Remove abort handler from the backtrace generator
The abort handler masks the exit status of the backtrace generator by
capturing the abort signal from the backtrace handler and exiting with
zero. Because the output of the backtrace generator is meant to be piped
to `bt_test.py`, its exit status is unimportant and is currently
ignored.
The abort handler calls `exit(3)` which is not asynchronous-signal-safe
and calling it in this context is undefined behavior [0].
Closes ticket 21026.
[0] https://www.securecoding.cert.org/confluence/x/34At
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/ticket21026 | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/changes/ticket21026 b/changes/ticket21026 new file mode 100644 index 0000000000..530a52c95e --- /dev/null +++ b/changes/ticket21026 @@ -0,0 +1,3 @@ + o Minor bugfixes (testing): + - Remove undefined behavior from the backtrace generator by removing + its signal handler. Fixes bug 21026; bugfix on 0.2.5.2-alpha. |