diff options
| author | Nick Mathewson <nickm@torproject.org> | 2012-09-13 11:45:05 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2012-09-13 11:45:05 -0400 |
| commit | c8b98ba41ce37662cf14fdb3c6a74ae83b8b0bf8 (patch) | |
| tree | 31a16ace0d585fb8491e4d3edf9be00f8a578ef0 /changes | |
| parent | 582f2187a769ea723f6bf13bc91f7a4b3c861408 (diff) | |
| download | tor-c8b98ba41ce37662cf14fdb3c6a74ae83b8b0bf8.tar.gz tor-c8b98ba41ce37662cf14fdb3c6a74ae83b8b0bf8.zip | |
Reject votes (not consensuses) with >64 known-flags
Our flag voting code needs to handle unrecognized flags, so it stores
them in a 64-bit bitfield. But we never actually checked for too many
flags, so we were potentially doing stuff like U64_LITERAL(1)<<flagnum
with flagnum >= 64. That's undefined behavior.
Fix for bug 6833; bugfix on 0.2.0.1-alpha.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug6833 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changes/bug6833 b/changes/bug6833 new file mode 100644 index 0000000000..4a6a5d3bbd --- /dev/null +++ b/changes/bug6833 @@ -0,0 +1,4 @@ + o Minor bugfixes (directory authority): + - Reject consensus votes with more than 64 known-flags. We aren't even + close to that limit yet, and our code doesn't handle it + correctly. Fixes bug 6833; bugfix on 0.2.0.1-alpha. |