diff options
| author | teor <teor2345@gmail.com> | 2014-10-20 02:52:21 +1100 |
|---|---|---|
| committer | teor <teor2345@gmail.com> | 2014-10-20 02:52:21 +1100 |
| commit | 879b39e1a8ae11060acd4db142f6d9d619e351a3 (patch) | |
| tree | fc0364e83b460e5b8723e4c91e98eae16d59aeb3 /changes | |
| parent | d7b13543e2305de38f7e17e7bcd1e5174fd89152 (diff) | |
| download | tor-879b39e1a8ae11060acd4db142f6d9d619e351a3.tar.gz tor-879b39e1a8ae11060acd4db142f6d9d619e351a3.zip | |
Further unit test tor_timegm and parse_rfc1123_time
Add unit tests for tor_timegm signed overflow,
tor_timegm and parse_rfc1123_time validity checks,
and correct_tm year clamping.
Unit tests (visible) fixes in bug 13476.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug13476-improve-time-handling | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/changes/bug13476-improve-time-handling b/changes/bug13476-improve-time-handling index 1fe60c642f..94ab95bf7c 100644 --- a/changes/bug13476-improve-time-handling +++ b/changes/bug13476-improve-time-handling @@ -1,6 +1,6 @@ o Minor bugfixes: - Set the correct day of year value when the system's localtime(_r) - or gmtime(_r) functions fail to set struct tm. + or gmtime(_r) functions fail to set struct tm. Not externally visible. Fixes bug 13476. - Avoid unlikely signed integer overflow in tor_timegm on systems with 32-bit time_t. @@ -11,5 +11,10 @@ Improves HTTP header validation. Implemented with bug 13476. - Clamp year values returned by system localtime(_r) and gmtime(_r) - to year 1. This ensures tor can read any values it might write out. + to year 1 in correct_tm. This ensures tor can read any values it + writes out. Fixes bug 13476. + o Minor enhancements (testing): + - Add unit tests for tor_timegm signed overflow, tor_timegm and + parse_rfc1123_time validity checks, correct_tm year clamping. + Unit tests (visible) fixes in bug 13476. |