aboutsummaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2017-02-07 10:58:02 -0500
committerNick Mathewson <nickm@torproject.org>2017-02-14 16:10:27 -0500
commit194e31057fbf07d6bdf4b62d26e1a9db334e5f1c (patch)
tree5dfedea08b7fb6b4bc0a0e2cae42e3f0afb1f77f /changes
parent635c5a8a92c8066412645b291817eadcc82d8f8f (diff)
downloadtor-194e31057fbf07d6bdf4b62d26e1a9db334e5f1c.tar.gz
tor-194e31057fbf07d6bdf4b62d26e1a9db334e5f1c.zip
Avoid integer underflow in tor_version_compare.
Fix for TROVE-2017-001 and bug 21278. (Note: Instead of handling signed ints "correctly", we keep the old behavior, except for the part where we would crash with -ftrapv.)
Diffstat (limited to 'changes')
-rw-r--r--changes/trove-2017-001.28
1 files changed, 8 insertions, 0 deletions
diff --git a/changes/trove-2017-001.2 b/changes/trove-2017-001.2
new file mode 100644
index 0000000000..3ef073cf9f
--- /dev/null
+++ b/changes/trove-2017-001.2
@@ -0,0 +1,8 @@
+ o Major bugfixes (parsing):
+ - Fix an integer underflow bug when comparing malformed Tor versions.
+ This bug is harmless, except when Tor has been built with
+ --enable-expensive-hardening, which would turn it into a crash;
+ or on Tor 0.2.9.1-alpha through Tor 0.2.9.8, which were built with
+ -ftrapv by default.
+ Part of TROVE-2017-001. Fixes bug 21278; bugfix on
+ 0.0.8pre1. Found by OSS-Fuzz.