diff options
author | Nick Mathewson <nickm@torproject.org> | 2021-10-19 15:16:49 -0400 |
---|---|---|
committer | Alexander Færøy <ahf@torproject.org> | 2021-10-20 18:38:39 +0000 |
commit | bcc953307b571df5b640f9fbc299b93c74d3847f (patch) | |
tree | aaa08a16c78d6d905fdf353772fc4e0e9ab4a17e /changes | |
parent | d455f9e18a9cef290b9976974065c83f13e16832 (diff) | |
download | tor-bcc953307b571df5b640f9fbc299b93c74d3847f.tar.gz tor-bcc953307b571df5b640f9fbc299b93c74d3847f.zip |
Move "Didn't recognize cell, but circ stops here" into heartbeat.
When we looked, this was the third most frequent message at
PROTOCOL_WARN, and doesn't actually tell us what to do about it.
Now:
* we just log it at info
* we log it only once per circuit
* we report, in the heartbeat, how many times it happens, how many
cells it happens with per circuit, and how long these circuits
have been alive (on average).
Fixes the final part of #40400.
Diffstat (limited to 'changes')
-rw-r--r-- | changes/bug40400_part3 | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug40400_part3 b/changes/bug40400_part3 new file mode 100644 index 0000000000..b78e800229 --- /dev/null +++ b/changes/bug40400_part3 @@ -0,0 +1,7 @@ + o Minor features (logging, heartbeat): + - When a relay receives a cell that isn't encrypted properly for + it, but the relay is the last hop on the circuit, the relay + now counts how many cells of this kind it receives, on how + many circuits, and reports this information in the log. + Previously, we'd log each cell at PROTOCOL_WARN level, which + is far too verbose to be useful. Fixes part of ticket 40400. |