diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-04-02 10:41:12 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-04-25 14:13:03 -0400 |
| commit | dbfe1a14e44647a4d5f27f8d495f3468208d75dd (patch) | |
| tree | 019b889b40e0390898c3ae18ad4132926c4b4d91 /changes | |
| parent | f18b7dc4731bcb853db92a0faaa4ec03d6ef5586 (diff) | |
| download | tor-dbfe1a14e44647a4d5f27f8d495f3468208d75dd.tar.gz tor-dbfe1a14e44647a4d5f27f8d495f3468208d75dd.zip | |
When parsing a multiline controller command, be careful with linebreaks
The first line break in particular was mishandled: it was discarded
if no arguments came before it, which made it impossible to
distinguish arguments from the first line of the body.
To solve this, we need to allocate a copy of the command rather than
using NUL to separate it, since we might have "COMMAND\n" as our input.
Fixes ticket 29984.
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/ticket29984 | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/ticket29984 b/changes/ticket29984 new file mode 100644 index 0000000000..8631dff27b --- /dev/null +++ b/changes/ticket29984 @@ -0,0 +1,5 @@ + o Minor bugfixes (controller protocol): + - Teach the controller parser to correctly distinguish an object + preceded by an argument list from one without. Previously, it + couldn't distinguish an argument list from the first line of a + multiline object. Fixes bug 29984; bugfix on 0.2.3.8-alpha. |