diff options
author | David Goulet <dgoulet@torproject.org> | 2021-12-13 10:22:29 -0500 |
---|---|---|
committer | David Goulet <dgoulet@torproject.org> | 2021-12-13 10:47:46 -0500 |
commit | cda7acb35d40c505dc4d2c3b55d611faab189477 (patch) | |
tree | d7abd9ddbb3fc2ab8fc418dd6a20a6eda4f54cc3 /changes | |
parent | a78dafbf7ce5d6fc6d4b6e7ddc7e0714bd377c2e (diff) | |
download | tor-cda7acb35d40c505dc4d2c3b55d611faab189477.tar.gz tor-cda7acb35d40c505dc4d2c3b55d611faab189477.zip |
relay: Don't make DNS timeout trigger an overload
Tor has configure libevent to attempt up to 3 times a DNS query for a
maximum of 5 seconds each. Once that 5 seconds has elapsed, it consider
the query "Timed Out" but tor only gets a timeout if all 3 attempts have
failed.
For example, using Unbound, it has a much higher threshold of timeout.
It is well defined in
https://www.nlnetlabs.nl/documentation/unbound/info-timeout/ and has
some complexity to it. But the gist is that if it times out, it will be
much more than 5 seconds.
And so the Tor DNS timeouts are more of a "UX issue" rather than a
"network issue". For this reason, we are removing this metric from the
overload general signal.
See https://gitlab.torproject.org/tpo/network-health/team/-/issues/139
for more information.
Fixes #40527
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'changes')
-rw-r--r-- | changes/ticket40527 | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/ticket40527 b/changes/ticket40527 new file mode 100644 index 0000000000..631b3d4bb9 --- /dev/null +++ b/changes/ticket40527 @@ -0,0 +1,5 @@ + o Major bugfixes (relay, overload): + - Don't make Tor DNS timeout trigger an overload general state. These + timeouts are different from DNS server timeout. They have to be seen as + timeout related to UX and not because of a network problem. Fixes bug + 40527; bugfix on 0.4.6.1-alpha. |