diff options
| author | Alexander Færøy <ahf@torproject.org> | 2019-10-17 16:39:05 +0200 |
|---|---|---|
| committer | Alexander Færøy <ahf@torproject.org> | 2019-10-17 20:52:22 +0200 |
| commit | 85b4a5c27659a7d162c2e476e1e0dfbeefd73095 (patch) | |
| tree | 61a0828d9098b34ff909aac5365498d334bfabac /changes | |
| parent | 8ac9af2330e99032445055d6728e9b3fe34a3470 (diff) | |
| download | tor-85b4a5c27659a7d162c2e476e1e0dfbeefd73095.tar.gz tor-85b4a5c27659a7d162c2e476e1e0dfbeefd73095.zip | |
Handle errors from execve() in the Unix process backend more gracefully.
This patch removes a call to tor_assert_unreached() after execve()
failed. This assertion leads to the child process emitting a stack trace
on its standard output, which makes the error harder for the user to
demystify, since they think it is an internal error in Tor instead of
"just" being a "no such file or directory" error.
The process will now instead output "Error from child process: X" where
X is the stringified version of the errno value.
See: https://bugs.torproject.org/31810
Diffstat (limited to 'changes')
| -rw-r--r-- | changes/bug31810 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changes/bug31810 b/changes/bug31810 new file mode 100644 index 0000000000..628d12f09b --- /dev/null +++ b/changes/bug31810 @@ -0,0 +1,4 @@ + o Minor bugfixes (process management): + - Remove assertion in the Unix process backend. This assertion would trigger + when a new process is spawned where the executable is not found leading to + a stack trace from the child process. Fixes bug 31810; bugfix on 0.4.0.1-alpha. |