diff options
author | Nick Mathewson <nickm@torproject.org> | 2021-05-07 12:09:41 -0400 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2021-05-07 12:12:11 -0400 |
commit | f5acfe67238a331bf8a6e94715163949999f27e7 (patch) | |
tree | 1a62e226784d301eb97ac464c3076702ef28174d /changes | |
parent | 7c86f34340acf7d8cf35501e71b03f2feba1245e (diff) | |
download | tor-f5acfe67238a331bf8a6e94715163949999f27e7.tar.gz tor-f5acfe67238a331bf8a6e94715163949999f27e7.zip |
Add a sandbox workaround for Glibc 2.33
This change permits the newfstatat() system call, and fixes issues
40382 (and 40381).
This isn't a free change. From the commit:
// Libc 2.33 uses this syscall to implement both fstat() and stat().
//
// The trouble is that to implement fstat(fd, &st), it calls:
// newfstatat(fs, "", &st, AT_EMPTY_PATH)
// We can't detect this usage in particular, because "" is a pointer
// we don't control. And we can't just look for AT_EMPTY_PATH, since
// AT_EMPTY_PATH only has effect when the path string is empty.
//
// So our only solution seems to be allowing all fstatat calls, which
// means that an attacker can stat() anything on the filesystem. That's
// not a great solution, but I can't find a better one.
Diffstat (limited to 'changes')
-rw-r--r-- | changes/ticket40382 | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changes/ticket40382 b/changes/ticket40382 new file mode 100644 index 0000000000..5ac1b771b9 --- /dev/null +++ b/changes/ticket40382 @@ -0,0 +1,6 @@ + o Minor features (compatibility, Linux seccomp sandbox): + - Add a workaround to enable the Linux sandbox to work correctly + on systems running Glibc 2.33. These versions have started + using the fstatat() system call, which previously our sandbox did not + allow. + Closes ticket 40382; see the ticket for a discussion of tradeoffs. |