aboutsummaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2015-06-22 13:51:56 -0400
committerNick Mathewson <nickm@torproject.org>2015-06-22 13:51:56 -0400
commite0b7598833238766b157f8eb799f448dac4c1283 (patch)
tree454d8d79c9cdd25093f63eeb0db9899cbdd8142c /changes
parentc8cb55659acca96530a1d7f54bb96cac84626e17 (diff)
downloadtor-e0b7598833238766b157f8eb799f448dac4c1283.tar.gz
tor-e0b7598833238766b157f8eb799f448dac4c1283.zip
Repair breakage in early-error case of microdesc parsing
When I fixed #11243, I made it so we would take the digest of a descriptor before tokenizing it, so we could desist from download attempts if parsing failed. But when I did that, I didn't remove an assertion that the descriptor began with "onion-key". Usually, this was enforced by "find_start_of_next_microdescriptor", but when find_start_of_next_microdescriptor returned NULL, the assertion was triggered. Fixes bug 16400. Thanks to torkeln for reporting and cypherpunks_backup for diagnosing and writing the first fix here.
Diffstat (limited to 'changes')
-rw-r--r--changes/bug164005
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/bug16400 b/changes/bug16400
new file mode 100644
index 0000000000..3e5f9c5843
--- /dev/null
+++ b/changes/bug16400
@@ -0,0 +1,5 @@
+ o Major bugfixes:
+ - Do not crash with an assertion error when parsing certain kinds
+ of malformed or truncated microdescriptors. Fixes bug 16400;
+ bugfix on 0.2.6.1-alpha. Found by "torkeln"; fix based on a patch by
+ "cypherpunks_backup".