aboutsummaryrefslogtreecommitdiff
path: root/changes
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2018-09-12 08:57:18 -0400
committerNick Mathewson <nickm@torproject.org>2018-09-12 08:57:18 -0400
commit73a37d1e547d996515e2a0ffea8331bb535d2841 (patch)
tree8b093a8bba5ebf4eab4dcf3188a88125932b12d6 /changes
parent198b6354e6c58ab4276461b5215487b8e9c15683 (diff)
downloadtor-73a37d1e547d996515e2a0ffea8331bb535d2841.tar.gz
tor-73a37d1e547d996515e2a0ffea8331bb535d2841.zip
Check waitpid return value and exit status in tinytest.c
It's possible for a unit test to report success via its pipe, but to fail as it tries to clean up and exit. Notably, this happens on a leak sanitizer failure. Fixes bug 27658; bugfix on 0.2.2.4-alpha when tinytest was introduced.
Diffstat (limited to 'changes')
-rw-r--r--changes/bug276586
1 files changed, 6 insertions, 0 deletions
diff --git a/changes/bug27658 b/changes/bug27658
new file mode 100644
index 0000000000..8cc0aa4714
--- /dev/null
+++ b/changes/bug27658
@@ -0,0 +1,6 @@
+ o Minor bugfixes (testing):
+ - If a unit test running in a subprocess exits abnormally or with a
+ nonzero status code, treat the test as having failed, even if
+ the test reported success. Without this fix, memory leaks don't cause
+ cause the tests to fail, even with LeakSanitizer. Fixes bug 27658;
+ bugfix on 0.2.2.4-alpha.