diff options
| author | Nick Mathewson <nickm@torproject.org> | 2020-10-28 09:39:21 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2020-10-28 09:41:51 -0400 |
| commit | 511822529ae1710e141bc26199ec5ff1d1abcd16 (patch) | |
| tree | 995c016627a6921805bd3fc335a80132cc3109f8 /changes/ticket32178 | |
| parent | 4520fbc05e2e3f8288b7e27c45bb2aecbc849f33 (diff) | |
| download | tor-511822529ae1710e141bc26199ec5ff1d1abcd16.tar.gz tor-511822529ae1710e141bc26199ec5ff1d1abcd16.zip | |
Revise fix for bug 32178 (spaces at end of log msg).
The loop in the earlier patch would invoke undefined behavior in two
ways: First, it would check whether it was looking at a space before
it checked whether the pointer was in-range. Second, it would let a
pointer reach a position _before_ the start of a string, which is
not allowed.
I've removed the assertion about empty messages: empty messages can
be their own warning IMO.
I've also added tests for this formatting code, to make sure it
actually works.
Diffstat (limited to 'changes/ticket32178')
| -rw-r--r-- | changes/ticket32178 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/changes/ticket32178 b/changes/ticket32178 index ae8554d8a0..c13e490cb0 100644 --- a/changes/ticket32178 +++ b/changes/ticket32178 @@ -1,3 +1,3 @@ o Minor bugfixes (logging): - Remove trailing whitespaces from control event log messages. Fixes bug - 32178. + 32178; bugfix on 0.1.1.1-alpha. Based on a patch by Amadeusz Pawlik. |