diff options
author | Karsten Loesing <karsten.loesing@gmx.net> | 2015-02-13 11:32:35 +0100 |
---|---|---|
committer | teor <teor2345@gmail.com> | 2015-05-06 18:05:16 +1000 |
commit | dad5eb7e1f3c92974c7bcaaea325a05233a27494 (patch) | |
tree | a80bcfcbf8204e7230aeb93302472585b9ebe62b /changes/laplace-edge-cases | |
parent | b3832e0b7f95e8082acce1be6505179d38f30d14 (diff) | |
download | tor-dad5eb7e1f3c92974c7bcaaea325a05233a27494.tar.gz tor-dad5eb7e1f3c92974c7bcaaea325a05233a27494.zip |
Tweak teor's and dgoulet's #13192 patches.
- Rewrite changes file.
- Avoid float comparison with == and use <= instead.
- Add teor's tor_llround(trunc(...)) back to silence clang warnings.
- Replace tt_assert() with tt_i64_op() and friends.
- Fix whitespace and a comment.
Diffstat (limited to 'changes/laplace-edge-cases')
-rw-r--r-- | changes/laplace-edge-cases | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/changes/laplace-edge-cases b/changes/laplace-edge-cases index 266b119bd9..6c8c77b040 100644 --- a/changes/laplace-edge-cases +++ b/changes/laplace-edge-cases @@ -1,11 +1,8 @@ - o Minor bugfixes: - - Handle edge cases in the laplace functions: - * avoid division by zero - * avoid taking the log of zero - * silence clang type conversion warnings using round and trunc - * consistently check for overflow in round_*_to_next_multiple_of - - Add tests for laplace edge cases: - * check add_laplace_noise with maximal values - * check round_*_to_next_multiple_of with additional values - * check round_*_to_next_multiple_of with maximal values - Related to HS stats in #13192. + o Code simplifications and unit tests: + - Handle edge cases in the laplace functions: avoid division by zero, + avoid taking the log of zero, and silence clang type conversion + warnings using round and trunc. Add unit tests for edge cases with + maximal values. + - Consistently check for overflow in round_*_to_next_multiple_of + functions, and add unit tests with additional and maximal values. + |