summaryrefslogtreecommitdiff
path: root/changes/cid_450
diff options
context:
space:
mode:
authorNick Mathewson <nickm@torproject.org>2011-07-01 12:36:33 -0400
committerNick Mathewson <nickm@torproject.org>2011-07-01 12:38:05 -0400
commitd25feadebbf05d6fce55cfee1e3c8f928903f543 (patch)
treee3c4342442c9014e70c5874eb340c6a0cb133beb /changes/cid_450
parent010b8dd4f6e8e3c3d2e44ff589ff61cbf64b952a (diff)
downloadtor-d25feadebbf05d6fce55cfee1e3c8f928903f543.tar.gz
tor-d25feadebbf05d6fce55cfee1e3c8f928903f543.zip
Fix insanely large stack_allocation in log_credential_status
I'm not one to insist on C's miserly stack limits, but allocating a 256K array on the stack is too much even for me. Bugfix on 0.2.1.7-alpha. Found by coverity. Fixes CID # 450.
Diffstat (limited to 'changes/cid_450')
-rw-r--r--changes/cid_4505
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/cid_450 b/changes/cid_450
new file mode 100644
index 0000000000..2045fca239
--- /dev/null
+++ b/changes/cid_450
@@ -0,0 +1,5 @@
+ o Minor bugfixes:
+ - Don't stack-allocate the list of supplementary GIDs when we're
+ about to log them. Stack-allocating NGROUPS_MAX gid_t elements
+ could take up to 256K, which is way too much stack. Found by
+ Coverity; CID #450. Bugfix on 0.2.1.7-alpha.