diff options
| author | Nick Mathewson <nickm@torproject.org> | 2020-12-14 10:14:03 -0500 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2020-12-14 10:14:03 -0500 |
| commit | c4fe66e342292b45f29e9fd242b66a0ca27a7758 (patch) | |
| tree | 7fe88b96244cd7618c3b5fafff1f54d1aa54e88f /changes/bug40190 | |
| parent | fcae26adf710cf1fe393fde723e9a2caf6012b09 (diff) | |
| download | tor-c4fe66e342292b45f29e9fd242b66a0ca27a7758.tar.gz tor-c4fe66e342292b45f29e9fd242b66a0ca27a7758.zip | |
Socks5: handle truncated client requests correctly
Previously, our code would send back an error if the socks5 request
parser said anything but DONE. But there are other non-error cases,
like TRUNCATED: we shouldn't send back errors for them.
This patch lowers the responsibility for setting the error message
into the parsing code, since the actual type of the error message
will depend on what problem was encountered.
Fixes bug 40190; bugfix on 0.3.5.1-alpha.
Diffstat (limited to 'changes/bug40190')
| -rw-r--r-- | changes/bug40190 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changes/bug40190 b/changes/bug40190 new file mode 100644 index 0000000000..0f3d6941dc --- /dev/null +++ b/changes/bug40190 @@ -0,0 +1,4 @@ + o Minor bugfixes (SOCKS5): + - Handle partial socks5 messages correctly. Previously, our code would + send an incorrect error message if it got a socks5 request that wasn't + complete. Fixes bug 40190; bugfix on 0.3.5.1-alpha. |