diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-08-06 11:11:06 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-08-06 11:11:06 -0400 |
| commit | 0849d2a2fdaeea2871f32bed35d410f19703aae1 (patch) | |
| tree | b41e92f65f462605ecf5dc5076f43e9c15561539 /changes/bug31343 | |
| parent | fb977f8cac99c008f11e054f07b8c4be5fc5a0c5 (diff) | |
| download | tor-0849d2a2fdaeea2871f32bed35d410f19703aae1.tar.gz tor-0849d2a2fdaeea2871f32bed35d410f19703aae1.zip | |
Avoid using labs() on time_t in channeltls.c
On some windows builds, time_t is 64 bits but long is not. This is
causing appveyor builds to fail.
Also, one of our uses of labs() on time_t was logically incorrect:
it was telling us to accept NETINFO cells up to three minutes
_before_ the message they were responding to, which doesn't make
sense.
This patch adds a time_abs() function that we should eventually move
to intmath.h or something. For now, though, it will make merges
easier to have it file-local in channeltls.c.
Fixes bug 31343; bugfix on 0.2.4.4-alpha.
Diffstat (limited to 'changes/bug31343')
| -rw-r--r-- | changes/bug31343 | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/changes/bug31343 b/changes/bug31343 new file mode 100644 index 0000000000..17a8057ead --- /dev/null +++ b/changes/bug31343 @@ -0,0 +1,9 @@ + o Minor bugfixes (compilation): + - Avoid using labs() on time_t, which can cause compilation warnings + on 64-bit Windows builds. Fixes bug 31343; bugfix on 0.2.4.4-alpha. + + o Minor bugfixes (clock skew detection): + - Don't believe clock skew results from NETINFO cells that appear to + arrive before the VERSIONS cells they are responding to were sent. + Previously, we would accept them up to 3 minutes "in the past". + Fixes bug 31343; bugfix on 0.2.4.4-alpha. |