diff options
| author | Nick Mathewson <nickm@torproject.org> | 2019-09-17 09:09:36 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2019-09-17 09:13:25 -0400 |
| commit | 3c97ab3c24ba4a133377c7ec6ec89cc6903ffb2e (patch) | |
| tree | 97a9fbc17d2ca0c4099db599992fa4a566eb0c15 /changes/bug31107 | |
| parent | 5a1c3e44f758cda18bb0a0a8ef7c94a0122c85e4 (diff) | |
| download | tor-3c97ab3c24ba4a133377c7ec6ec89cc6903ffb2e.tar.gz tor-3c97ab3c24ba4a133377c7ec6ec89cc6903ffb2e.zip | |
Treat an unexpected constant-sized VERSIONS cell as a PROTOCOL_WARN.
We previously used tor_fragile_assert() to declare that this case
could not happen: VERSIONS cells are always supposed to be
variable-sized, right?
This is incorrect, though. On a v1 link protocol connection, all
cells are fixed-sized. There aren't supposed to be any VERSIONS
cells with this version of the protocol, but apparently, somebody
was messing up. (The v1 link protocol is obsolete, so probably the
implementer responsible didn't mean to be using it.)
Fixes bug 31107. Bugfix on 0.2.4.4-alpha, when we introduced a
tor_fragile_assert() for this case.
Diffstat (limited to 'changes/bug31107')
| -rw-r--r-- | changes/bug31107 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changes/bug31107 b/changes/bug31107 new file mode 100644 index 0000000000..9652927c30 --- /dev/null +++ b/changes/bug31107 @@ -0,0 +1,4 @@ + o Minor bugfixes (logging, protocol violations): + - Do not log a nonfatal assertion failure when receiving a VERSIONS + cell on a connection using the obsolete v1 link protocol. Log a + protocol_warn instead. Fixes bug 31107; bugfix on 0.2.4.4-alpha. |