diff options
author | Nick Mathewson <nickm@torproject.org> | 2018-06-11 17:49:38 -0400 |
---|---|---|
committer | Nick Mathewson <nickm@torproject.org> | 2018-06-21 08:56:20 -0400 |
commit | cacf326e78bee705d14dd61329160c8d71fa3ef8 (patch) | |
tree | b79a0e4a370422ca7a98685abcc2ad3494f9c34b /changes/bug25787 | |
parent | fa195626bdc12c99d60c7a909b9e1b632bc0c4f4 (diff) | |
download | tor-cacf326e78bee705d14dd61329160c8d71fa3ef8.tar.gz tor-cacf326e78bee705d14dd61329160c8d71fa3ef8.zip |
Revise geoip tests to not require paths of actual geoip config
When I wrote the first one of these, it needed the path of the geoip
file. But that doesn't translate well in at least two cases:
- Mingw, where the compile-time path is /c/foo/bar and the
run-time path is c:\foo\bar.
- Various CI weirdnesses, where we cross-compile a test binary,
then copy it into limbo and expect it to work.
Together, these problems precluded these tests running on windows.
So, instead let's just generate some minimal files ourselves, and
test against them.
Fixes bug 25787
Diffstat (limited to 'changes/bug25787')
-rw-r--r-- | changes/bug25787 | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug25787 b/changes/bug25787 new file mode 100644 index 0000000000..3041e8a603 --- /dev/null +++ b/changes/bug25787 @@ -0,0 +1,7 @@ + o Minor bugfixes (testing): + - Instead of trying to read the geoip configuration files from within the + unit tests, instead create our own ersatz files with just enough + geoip data in the format we expect. Trying to read from the source + directory created problems on Windows with mingw, where the + build system's paths are not the same as the platform's paths. + Fixes bug 25787; bugfix on 0.3.4.1-alpha. |