diff options
| author | David Goulet <dgoulet@torproject.org> | 2017-12-19 16:20:36 -0500 |
|---|---|---|
| committer | David Goulet <dgoulet@torproject.org> | 2017-12-21 09:32:04 -0500 |
| commit | 885ba513ff709eb86a71c7daf7c23aafab4862a8 (patch) | |
| tree | c4007d0ca43b2bb374d68788f45485d8a154c99b /changes/bug24665 | |
| parent | 7e45720cf4c88bff92a6de23ccbdd96d4cab2be5 (diff) | |
| download | tor-885ba513ff709eb86a71c7daf7c23aafab4862a8.tar.gz tor-885ba513ff709eb86a71c7daf7c23aafab4862a8.zip | |
sched: Consider extra_space even if negative in KIST
With extra_space negative, it means that the "notsent" queue is quite large so
we must consider that value with the current computed tcp_space. If we end up
to have negative space, we should not add more data to the kernel since the
notsent queue is just too filled up.
Fixes #24665
Signed-off-by: David Goulet <dgoulet@torproject.org>
Diffstat (limited to 'changes/bug24665')
| -rw-r--r-- | changes/bug24665 | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changes/bug24665 b/changes/bug24665 new file mode 100644 index 0000000000..f950d9dd01 --- /dev/null +++ b/changes/bug24665 @@ -0,0 +1,6 @@ + o Major bugfixes (KIST, scheduler): + - The KIST scheduler did not correctly account for data already enqueued + in each connection's send socket buffer, particularly in cases when the + TCP/IP congestion window was reduced between scheduler calls. This + situation lead to excessive per-connection buffering in the kernel, and + a potential memory DoS. Fixes bug 24665; bugfix on 0.3.2.1-alpha. |