diff options
| author | teor <teor2345@gmail.com> | 2017-09-11 14:21:48 +1000 |
|---|---|---|
| committer | teor <teor2345@gmail.com> | 2017-09-13 09:46:17 +1000 |
| commit | c86013291bd26f3497e9efcf96125342d97cba33 (patch) | |
| tree | c393a54f232db03663caedd756be5436556da4c1 /changes/bug23470 | |
| parent | 3138fe2e694a7036d28427ee3d76e639d15e4bc0 (diff) | |
| download | tor-c86013291bd26f3497e9efcf96125342d97cba33.tar.gz tor-c86013291bd26f3497e9efcf96125342d97cba33.zip | |
Stop relays calling directory_fetches_from_authorities on dir downloads
This change refactors find_dl_schedule() to only call dependent functions
as needed. In particular, directory_fetches_from_authorities() only needs
to be called on clients.
Stopping spurious directory_fetches_from_authorities() calls on every
download on public relays has the following impacts:
* fewer address resolution attempts, particularly those mentioned in 21789
* fewer descriptor rebuilds
* fewer log messages, particularly those limited in 20610
Fixes 23470 in 0.2.8.1-alpha.
The original bug was introduced in commit 35bbf2e as part of prop210.
Diffstat (limited to 'changes/bug23470')
| -rw-r--r-- | changes/bug23470 | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/changes/bug23470 b/changes/bug23470 new file mode 100644 index 0000000000..33367b3a30 --- /dev/null +++ b/changes/bug23470 @@ -0,0 +1,6 @@ + o Minor bugfix (relay address resolution): + - Avoid unnecessary calls to directory_fetches_from_authorities() + on relays. This avoids spurious address resolutions and + descriptor rebuilds. This is a mitigation for 21789. The original + bug was introduced in commit 35bbf2e as part of prop210. + Fixes 23470 in 0.2.8.1-alpha. |