diff options
| author | Nick Mathewson <nickm@torproject.org> | 2017-07-25 10:14:24 -0400 |
|---|---|---|
| committer | Nick Mathewson <nickm@torproject.org> | 2017-07-26 12:57:49 -0400 |
| commit | 32b9edeb91a7d9b9752083622d1ce400f45e42ea (patch) | |
| tree | c5c862b812f6d91116159101de9eabd8e79bee21 /changes/bug23030_029 | |
| parent | 6d3c5b8fb5784240232a9265049b9e1660270df7 (diff) | |
| download | tor-32b9edeb91a7d9b9752083622d1ce400f45e42ea.tar.gz tor-32b9edeb91a7d9b9752083622d1ce400f45e42ea.zip | |
Fix build warnings from Coverity related to our BUG macro
In the Linux kernel, the BUG() macro causes an instant panic. Our
BUG() macro is different, however: it generates a nonfatal assertion
failure, and is usable as an expression.
Additionally, this patch tells util_bug.h to make all assertion
failures into fatal conditions when we're building with a static
analysis tool, so that the analysis tool can look for instances
where they're reachable.
Fixes bug 23030.
Diffstat (limited to 'changes/bug23030_029')
| -rw-r--r-- | changes/bug23030_029 | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/changes/bug23030_029 b/changes/bug23030_029 new file mode 100644 index 0000000000..89a1b507d7 --- /dev/null +++ b/changes/bug23030_029 @@ -0,0 +1,7 @@ + o Minor bugfixes (coverity builds): + - Avoid Coverity build warnings related to our BUG() macro. By + default, Coverity treats BUG() as the Linux kernel does: an + instant abort(). We need to override that so our BUG() macro + doesn't prevent Coverity from analyzing functions that use it. + Fixes bug 23030; bugfix on 0.2.9.1-alpha. + |