diff options
author | teor <teor2345@gmail.com> | 2016-12-03 08:25:50 +1100 |
---|---|---|
committer | teor <teor2345@gmail.com> | 2016-12-03 09:10:46 +1100 |
commit | 8a0ea3ee43da0063c2546092662fa7ce4900bc2c (patch) | |
tree | 6215ad829910b7311a67e5f8f5357683f82c703b /changes/bug20860 | |
parent | 93c62f5ac1757f171c8a0b51f8320f48eba885a6 (diff) | |
download | tor-8a0ea3ee43da0063c2546092662fa7ce4900bc2c.tar.gz tor-8a0ea3ee43da0063c2546092662fa7ce4900bc2c.zip |
Use a temporary service list when validating and adding hidden services
This resolves two issues:
* the checks in rend_add_services were only being performed when adding
the service, and not when the service was validated,
(this meant that duplicate checks were not being performed, and some SETCONF
commands appeared to succeed when they actually failed), and
* if one service failed while services were being added, then the service
list would be left in an inconsistent state (tor dies when this happens,
but the code is cleaner now).
Fixes #20860.
Diffstat (limited to 'changes/bug20860')
-rw-r--r-- | changes/bug20860 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/changes/bug20860 b/changes/bug20860 new file mode 100644 index 0000000000..81b0dd8fc0 --- /dev/null +++ b/changes/bug20860 @@ -0,0 +1,4 @@ + o Minor bugfixes (hidden services): + - Stop ignoring duplicate hidden services when validating: this could + lead to a crash when those services were created. + Fixes bug 20860; bugfix on 20559; not in any released version of tor. |