diff options
| author | Arthur Edelstein <arthuredelstein@gmail.com> | 2017-12-05 20:23:02 -0800 |
|---|---|---|
| committer | Arthur Edelstein <arthuredelstein@gmail.com> | 2017-12-06 14:18:41 -0800 |
| commit | 2bd91dbd346d6dcaa718ad7b952264cbfb713db6 (patch) | |
| tree | fcd2be00a4429022c246404f16eb29d8a8c6b50b /changes/bug18859 | |
| parent | 5c03bb7c0ca55a17dae64d4a9d05dd88b3d712c8 (diff) | |
| download | tor-2bd91dbd346d6dcaa718ad7b952264cbfb713db6.tar.gz tor-2bd91dbd346d6dcaa718ad7b952264cbfb713db6.zip | |
Don't consider a port "handled" by an isolated circuit.
Previously, circuit_stream_is_being_handled incorrectly reported
that (1) an exit port was "handled" by a circuit regardless of
whether the circuit was already isolated in some way, and
(2) that a stream could be "handled" by a circuit even if their
isolation settings were incompatible.
As a result of (1), in Tor Browser, circuit_get_unhandled_ports was
reporting that all ports were handled even though all non-internal
circuits had already been isolated by a SOCKS username+password.
Therefore, circuit_predict_and_launch_new was declining to launch
new exit circuits. Then, when the user visited a new site in Tor
Browser, a stream with new SOCKS credentials would be initiated,
and the stream would have to wait while a new circuit with those
credentials could be built. That wait was making the
time-to-first-byte longer than it needed to be.
Now, clean, not-yet-isolated circuit(s) will be automatically
launched ahead of time and be ready for use whenever a new stream
with new SOCKS credentials (or other isolation criteria) is
initiated.
Fixes bug 18859. Thanks to Nick Mathewson for improvements.
Diffstat (limited to 'changes/bug18859')
| -rw-r--r-- | changes/bug18859 | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/changes/bug18859 b/changes/bug18859 new file mode 100644 index 0000000000..993074079c --- /dev/null +++ b/changes/bug18859 @@ -0,0 +1,5 @@ + o Minor bugfixes (circuit prediction): + - Fix circuit_stream_is_being_handled so it correctly reports on circuits + with isolation settings. Ports must not be said to be "handled" by + already-isolated circuits, and a stream can only be handled by a circuit + if their isolation settings are compatible. Fixes bug 18859. |